-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix DBG IBs warnings about EDM_ML_DEBUG redefined #34180
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34180/23391
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: Calibration/HcalCalibAlgos @smuzaffar, @civanch, @Dr15Jones, @malbouis, @kmaeshima, @cvuosalo, @makortel, @andrius-k, @mdhildreth, @ianna, @cmsbuild, @yuanchao, @jfernan2, @ahmad3213, @tlampen, @ErnestaP, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test unitTestsGroup_d had ERRORS ---> test standAloneWithMessageLoggerRunner had ERRORS Comparison SummarySummary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34180/23396
|
Pull request #34180 was updated. @smuzaffar, @civanch, @Dr15Jones, @malbouis, @kmaeshima, @cvuosalo, @makortel, @andrius-k, @mdhildreth, @ianna, @yuanchao, @jfernan2, @ahmad3213, @tlampen, @ErnestaP, @pohsun, @rvenditti, @francescobrivio can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36e41f/16109/summary.html Comparison SummarySummary:
|
+1 |
+1 |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
In DBG IBs ( build with
-g -O3 -DEDM_ML_DEBUG
flags) there many warnings about redefinition of EDM_ML_DEBUG. This PR proposes to either remove the definition from code or protect it by first checking if it is already set.